Description of changes

Adds a bunch of history outputs with the mxharvests dimension (max number of crop harvests per year; 2).

MAX_TLAI_PERHARV gives the maximum total LAI seen across the growing season.

20 other outputs give the biomass for five C pools (leaf, grain, stem, fine root, coarse root) at three crop phase transitions (emergence, anthesis, maturity) and harvest (which may not happen at maturity).

Also adds an option to suppress a warning about low gddmaturity, which I used during the CRU-JRA crop calendar work.

Specific notes

Contributors other than yourself, if any: None

CTSM Issues Fixed (include github issue #):

• Resolves CropPhenology: Rename leafout to gddtsoi #3696

Are answers expected to change (and if so in what way)? No

Any User Interface Changes (namelist or namelist defaults changes)? No

Does this create a need to change or add documentation? Did you do so? Will need to update non-FATES output list; no.

• Update non-FATES output list

Testing performed

✅ New unit tests

Pass.

✅ aux_clm

aux_clm reveals what seem to be threading problems with MAX_TLAI_PERHARV, which fails COMPARE_base_rest in ER[PS]_Ly3_P64x2 tests but not an ERS_Ly3 test. Resolved with a7e66aa.

• Redo

✅ Sense checks

• Using this script

To do

• Fix threading issue.
• Add HARVORGANC equivalent but JUST for grain. Will match what I have there for now, because grain is all CLM simulates by default. But it'll differ with the options underneath. (Do not name GRAIN unless you fix LPREPRSTRUCT test to handle this.) People should just use existing GRAINC_TO_(FOOD|SEED)_PERHARV outputs.
• Add support for for_testing_use_second_grain_pool and/or for_testing_use_repr_structure_pool true (or throw error in that case). See above.